Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): add netrc password to mask targets #603

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

This will help prevent accidental leakage of the netrc password used in builds

@ecrupper ecrupper requested a review from a team as a code owner September 27, 2024 17:11
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.51%. Comparing base (7ec1fe1) to head (0a4224d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   57.46%   57.51%   +0.04%     
==========================================
  Files         121      121              
  Lines        5205     5211       +6     
==========================================
+ Hits         2991     2997       +6     
  Misses       1988     1988              
  Partials      226      226              
Files with missing lines Coverage Δ
executor/linux/build.go 71.82% <100.00%> (+0.21%) ⬆️
executor/linux/stage.go 73.26% <100.00%> (+0.81%) ⬆️

@ecrupper ecrupper merged commit 9828b2a into main Sep 27, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/mask-netrc branch September 27, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants